Gracefully handle common errors in credential values #1026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1026 +/- ##
============================================
+ Coverage 66.14% 66.18% +0.03%
+ Complexity 3468 3466 -2
============================================
Files 739 739
Lines 17443 17425 -18
Branches 963 961 -2
============================================
- Hits 11537 11532 -5
+ Misses 5366 5357 -9
+ Partials 540 536 -4
Continue to review full report at Codecov.
|
|
@mediumTaj could you take another look real quick? I just had to add some null checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functional change in this PR is that exceptions are thrown for credential values surrounded by
{}or""characters. This prevents making a call to the service and provides a more helpful error message.Besides that, there was a lot of refactoring done with the credential logic in the SDK. Things had gotten a bit messy with the various changes we've had in auth methods and one-off fixes, so I consolidated some things to make it a bit clearer to work with. This should also make it easier to add the next auth feature coming soon 👀